Fix header link #1263
Merged
Fix header link #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinjiang
reviewed
Nov 9, 2017
| if (node !== wrapper) { | ||
| wrapper.appendChild(node) | ||
| } | ||
| } |
There was a problem hiding this comment.
I found that just remove these additions here and all the modifications in page.style could work (in Safari 11 in my Mac), which means just keeping setAttribute('data-scroll', '') only in function makeHeaderClickable is OK.
Jinjiang
reviewed
Nov 9, 2017
themes/vue/source/css/_settings.styl
Outdated
| @@ -23,7 +23,7 @@ $header-inner-height = 41px | |||
| $heading-padding-vertical = 10px | |||
| $header-height = $header-inner-height + $heading-padding-vertical * 2 | |||
| $mobile-header-height = 40px | |||
| $heading-link-padding-top = $content-padding-top | |||
| $mobile-heading-link-padding-top = $content-padding-top | |||
| $heading-link-padding-top = $header-height + $content-padding-top | |||
There was a problem hiding this comment.
For the former mistake, I advice to add some comment here and function makeHeaderClickable() (whatever it will become finally).
|
@Jinjiang Done. |
Justineo
force-pushed
the
fix-header-link
branch
from
cbb9f66 to
3051502
Compare
chrisvfritz
added a commit
that referenced
this pull request
Nov 15, 2017
This reverts commit b73f126.
|
Had to revert this unfortunately to fix #1273, but I'm happy to accept another similar PR. |
|
@chrisvfritz Fixed that in #1280.
|
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Nov 24, 2017
* update sponsor link * update sponsor image * Fix header link (vuejs#1263) * fix header link * fix cr
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Nov 24, 2017
This reverts commit b73f126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem that headers are covered by the top menu and also keep them clickable.